Feature/hexbin mapbox#2559
Conversation
|
Thank you very much for this pull request, it looks awesome! I should have some feedback for you in a couple of days. |
|
OK, so I think we'd like to merge this in time for the 4.9 release in a few weeks, but one change I would propose would be to include this under What do you think? PS: overall this is an excellent piece of work, and I can imagine reusing some of these utility functions elsewhere in the codebase, especially for automatic zoomlevel calculations etc, so "bravo"! |
|
At first I hesitated between plotly express and figure factory but it felt to me like figure factory was for more complex plots with multiple elements. Also I made this PR so that the call to Now I understand that there is not a traditional mapping between And glad that some of the util functions can be reused! |
|
OK, after some thought, I think I would like this to be in the I'm a little worried about the use of the private Finally, we'll also need a new documentation page with some examples of how to use it. This can just be a new Markdown file in |
|
OK, in that case, is it possible to call functions from |
|
I think it's totally fine for a figure factory to call public functions from PX like |
Hexbin_mapbox tests: 1) Aggregation results 2) Check build_dataframe behaviour
|
I added some tests. For now, I put them in I'll get on to the doc page soon. |
|
Thanks! The dendrogram error will be fixed soon: #2618 |
Documentation page.
|
This looks great, thank you! I'll do a couple of fixups in an additional commit and this will be released with 4.9 this week. |
|
Finishing up in #2638 if you want to keep track :) |
|
The thumbnail needs to go up in our S3 bucket, and I've just uploaded it there, FYI. https://images.plot.ly/plotly-documentation/thumbnail/hexbin_mapbox.jpg |
|
Thanks for keeping me updated and for the final tweaks 👍 |
|
The thanks go to you, for one of the most complete and obviously-awesome external pull requests I've ever seen :) |

Feature: hexbin_mapbox
Creates an hexagonal binning of lat/lon points and aggregates for a metric.
Documentation PR
doc/README.mdfiledoc-prodbranch OR it targets themasterbranchpxexample if at all possibleplotly.graph_objects as go/plotly.express as px/plotly.io as piodffig = <something>call is high up in each new/modified example (eitherpx.<something>ormake_subplotsorgo.Figure)fig.add_*andfig.update_*rather thango.Figure(data=..., layout=...)in every new/modified examplefig.add_shapeandfig.update_xaxesare used instead of bigfig.update_layoutcalls in every new/modified examplefig.show()is at the end of each new/modified exampleplotly.plot()andplotly.iplot()are not used in any new/modified exampleCode PR
plotly.graph_objects, my modifications concern thecodegenfiles and not generated files.modified existing tests.
new tutorial notebook (please see the doc checklist as well).